kicad-jlcpcb-tools icon indicating copy to clipboard operation
kicad-jlcpcb-tools copied to clipboard

rotation mapping automatically flip the rotation sign if the layer is top or bottom

Open gionag opened this issue 11 months ago • 3 comments

If i save a mapping for certain package on the top layer, when i use the same package on the opposite layer, also the sign of the rotation should change.

Should internally adapt the sign if the component is placed on top or bottom

Maybe is a recent change on jlcpcb portal

gionag avatar Sep 20 '23 09:09 gionag

Can you give an example so that I can test it?

Bouni avatar Oct 26 '23 05:10 Bouni

I came across the same (?) problem on my double sided board.

To my surprise the correction "sign" switching was already implemented here:

https://github.com/Bouni/kicad-jlcpcb-tools/blob/b764df8f686480bc7b494119e9beed2e891d7c8c/fabrication.py#L94-L112

After removing this condition (i.e. always True), I've gotten correct results on both sides. Strange.

dzid26 avatar Jan 04 '24 23:01 dzid26

I was able to reproduce the issue with standard kicad library footprint.

Example footprint is TO-277A with C895438 - rotation 90deg. Top: image Bottom: image

https://github.com/Springer-Electronics/kicad-jlcpcb-tools/commit/1bbae0f252927469f929b8575bad5881608db7fc fixes the problem.

dzid26 avatar Jan 10 '24 01:01 dzid26