kicad-jlcpcb-tools
kicad-jlcpcb-tools copied to clipboard
rotation mapping automatically flip the rotation sign if the layer is top or bottom
If i save a mapping for certain package on the top layer, when i use the same package on the opposite layer, also the sign of the rotation should change.
Should internally adapt the sign if the component is placed on top or bottom
Maybe is a recent change on jlcpcb portal
Can you give an example so that I can test it?
I came across the same (?) problem on my double sided board.
To my surprise the correction "sign" switching was already implemented here:
https://github.com/Bouni/kicad-jlcpcb-tools/blob/b764df8f686480bc7b494119e9beed2e891d7c8c/fabrication.py#L94-L112
After removing this condition (i.e. always True), I've gotten correct results on both sides. Strange.
I was able to reproduce the issue with standard kicad library footprint.
Example footprint is TO-277A
with C895438
- rotation 90deg.
Top:
Bottom:
https://github.com/Springer-Electronics/kicad-jlcpcb-tools/commit/1bbae0f252927469f929b8575bad5881608db7fc fixes the problem.