kicad-jlcpcb-tools icon indicating copy to clipboard operation
kicad-jlcpcb-tools copied to clipboard

No files are generated in the latest nightly 6.99.0-1615-g403992a6f4

Open Bouni opened this issue 2 years ago • 3 comments

Describe the bug When the generate fabrication files button is clicked, nothing happens.

To Reproduce Steps to reproduce the behavior:

  1. Click generate fabrication files
  2. Nothing happens

Expected behavior Gerbers, BOM and POS should be generated.

KiCad Version

Application: KiCad PCB Editor (64-bit)

Version: (6.99.0-1615-g403992a6f4), release build

Libraries:
	wxWidgets 3.1.5
	FreeType 2.11.1
	HarfBuzz 2.8.2
	FontConfig 2.13.1
	libcurl/7.78.0-DEV Schannel zlib/1.2.11

Platform: Windows 10 (build 19044), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Apr 11 2022 07:20:34
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.6.0
	Curl: 7.78.0-DEV
	ngspice: 36
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON

Bouni avatar Apr 13 '22 06:04 Bouni

The problem seems to be in this line: https://github.com/Bouni/kicad-jlcpcb-tools/blob/2022.04.02/fabrication.py#L117

When the stdout/stderr window of KiCAD is open the problem gets clear:

line 117, in generate_geber popt.SetExcludeEdgeLayer(True)
AttributeError: 'PCB_PLOT_PARAMS' object has no attribute 'SetExcludeEdgeLayer'

My best guess is that SetExcludeEdgeLayer has been removed or renamed in the latest version of KiCAD

Bouni avatar Apr 13 '22 06:04 Bouni

i saw that kicad's developers has changed the plot options in https://gitlab.com/kicad/code/kicad/-/commit/0bdbfe1446a80393f9251fe04c630190c936cc3c As it was important for me to include edges in gerber file (using CopperCAM), do you think will be possible to restore this functionality whitn new option SetPlotOnAllLayersSelection ? Many thenks

Robyrob avatar Aug 09 '22 14:08 Robyrob

@Robyrob I think it should be possible to add this back in using SetPlotOnAllLayersSelection but to do so I've to gigure out how to use that 😄

Bouni avatar Aug 11 '22 15:08 Bouni

https://gitlab.com/kicad/code/kicad/-/commit/31bad5baaad6162dfb6cf1c519f28519665d6174 I think this commit is breaking this line: https://github.com/Bouni/kicad-jlcpcb-tools/blob/2022.04.02/fabrication.py#L117

I cannot generate files in the latest nightly.

Sync- avatar Dec 02 '22 03:12 Sync-

It's been fixed in a recent Kicad commit! :)

Sync- avatar Dec 16 '22 17:12 Sync-