pi-apps icon indicating copy to clipboard operation
pi-apps copied to clipboard

Tidy up settings script

Open trn1ty opened this issue 1 year ago • 1 comments

I noticed there was some tricky IFS usage to separate file names, but shell can do that in a for loop anyway, so I went ahead and cleaned all that up as well as making some other small changes for readability. Functionality should be equivalent except that settings help shows a help screen now.

trn1ty avatar May 20 '24 10:05 trn1ty

echo and printf are both bash builtins, so I am not aware of any meaningful performance difference between the two. So when you use printf just like echo, is there a reason for that?

Why exchange this: echo "$output" for this? printf '%s\n' "$output" Do you find that to be more readable? Or is it somehow better practice?

We like code readability, and some of your changes here seem to make the code harder to read.

Botspot avatar May 20 '24 16:05 Botspot

Closing as stale as the author has not replied to comments.

theofficialgman avatar Sep 21 '24 23:09 theofficialgman