Botspot
For your information, a script in French with additions and deletions made.
Many of these changes seem to be:
- French translation
- Bash formatting changes that do not do anything.
- You have replaced all
[ ]statements with[[ ]]or(( )). This does not make the code run any faster or change behavior, and is considered bad practice. - You have encapsulated most variables in
${}unnecessarily.
- You have replaced all
- Removal of auto dependency installation
- Addition of WebDav drive type
- Other small tweaks to application logic in various places
I may have overlooked some other types of changes, and that is because bundling all changes together like that makes it extremely difficult to thoroughly compare. I could sit down and spend 2-5 hours on it, but as an open-source developer I'm not paid to do it and I have other things to do.
If you have specific fixes or improvements for CloudBuddy, please make a pull request with a minimal set of changes. https://docs.github.com/fr/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
Hello, Changes are indicated in begin of the script. (note that i have found an error do to automatic replacements of [] py [[ ]] -> creation of the desktop link). I don't know that [[ ]] and (( )) is considered like bad practice. It's a integration of bash -> Shebang is /usr/bin/bash. Don't intend to be portable !
I think this change important: When navigate in a cloud drive empty, you have one line (empty) in the browser. Could get some problem if this line is used. So I have just pass the open of the browser in this case and replace tjis with a warnng. An other important thing is to remove the call to zenity. yad is already here and is an evolution of zenity.
The title of my message is 'For information'. I do not ask nothing. I have just another message to indicate that cloudberry don't close in some situations. This is more important. Regards, JML
Envoyé avec un e-mail sécurisé Proton Mail.
Le mardi 28 octobre 2025 à 16:24, Botspot @.***> a écrit :
Botspot left a comment (Botspot/cloudbuddy#16)
Many of these changes seem to be:
French translation
Bash formatting changes that do not do anything.
You have replaced all [ ] statements with [[ ]] or (( )). This does not make the code run any faster or change behavior, and is considered bad practice.
You have encapsulated most variables in ${} unnecessarily.
Removal of auto dependency installation
Addition of WebDav drive type
Other small tweaks to application logic in various places
I may have overlooked some other types of changes, and that is because bundling all changes together like that makes it extremely difficult to thoroughly compare. I could sit down and spend 2-5 hours on it, but as an open-source developer I'm not paid to do it and I have other things to do.
If you have specific fixes or improvements for CloudBuddy, please make a pull request with a minimal set of changes. https://docs.github.com/fr/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>