botbuilder-community-js icon indicating copy to clipboard operation
botbuilder-community-js copied to clipboard

feat: Add support for a custom endpoint on botbuilder-storage-dynamodb

Open kayneb opened this issue 3 years ago • 1 comments

Description

This change updates botbuilder-storage-dynamodb to support a custom endpoint - useful when using something like localstack locally, and you want to point the adapter to that instead.

Unfortunately, this is an additional optional parameter to the adapter, and so to make the API simpler, adopting an options pattern for all parameters. This will enable easier extension of parameters in future. Given this adapter has only been downloaded ~40 times in the last week, it seems to be fairly low impact to release a new major version.

Test Plan

  • [x] Run localstack (which has a custom endpoint URL)
  • [x] Update our running application to conform to the new API shape of this plugin and set the endpoint option
  • [x] Verify app is able to interface with localstack
  • [x] Unit tests

kayneb avatar Aug 04 '22 06:08 kayneb

Unsure why the check is failing - doesn't appear related to this PR.

kayneb avatar Aug 04 '22 18:08 kayneb