BEMSimpleLineGraph icon indicating copy to clipboard operation
BEMSimpleLineGraph copied to clipboard

Published 20 hours ago • verified publisher icon Boris-Em

Feature Enhancement: Supply current popUp index parameter for lineGraph

Open xuzhiming opened this issue 8 years ago • 4 comments

Summary

supply current popUp index parameter for popUpSuffixForlineGraph and popUpPrefixForlineGraph

Feature Enhancement

This pull request enhance the following features:

  • #We sometimes may need know current popUp index when we display popUp suffix/prefix.

Notes

  • [x] I have run and ensured that this pull request passes all XCTests

xuzhiming avatar Mar 10 '16 03:03 xuzhiming

Hi @xuzhiming, First of all, thanks a lot for your contribution! I added a few in line comments. Please address those so that we can merge your pull request. Let me know if you have any questions!

Boris-Em avatar Mar 10 '16 18:03 Boris-Em

ok, I'll address those issues soon.

xuzhiming avatar Mar 11 '16 01:03 xuzhiming

Hi @Boris-Em , please check the latest commit.

xuzhiming avatar Mar 14 '16 02:03 xuzhiming

This looks great! It is a breaking change. Could you deprecate the old methods?

Sam-Spencer avatar Mar 19 '16 20:03 Sam-Spencer