BEMSimpleLineGraph icon indicating copy to clipboard operation
BEMSimpleLineGraph copied to clipboard

Wrong index in lineGraph:didTouchGraphWithClosestIndex: when more than 900 data points

Open crvo84 opened this issue 9 years ago • 5 comments

When touching the graph on a point after 900 data points, it calls the delegate method with 899 as index, even if it should be a higher index.

crvo84 avatar May 01 '15 16:05 crvo84

I can confirm this - any solution yet?

skuske avatar Jun 22 '15 08:06 skuske

This likely has something to do with the use of tags and the enum DotLastTag1000. BEMSimpleLineGraph isn't really designed to display more than 1000 points. That being said, it is bad design to use tags. We should probably look into another way to enumerate and access the graph's data points. That would fix this issue and some design issues as well...

Sam-Spencer avatar Feb 21 '16 22:02 Sam-Spencer

@Sam-Spencer, absolutely agree. Whether it is to fix this bug or not, tags are not a good idea.

Boris-Em avatar Feb 22 '16 00:02 Boris-Em

@crvo84 @skuske Pull request #263 looks promising as a fix for this issue. I will report back here once the review is complete.

Sam-Spencer avatar Jul 02 '16 20:07 Sam-Spencer

+1, I met too

ZacksTsang avatar Jan 30 '18 05:01 ZacksTsang