Chris H
Chris H
Hey, @johlju. Trying to rebase per our discussion in #60. However the tests are failing for resources that I'm not touching, in a way that I haven't seen before -...
@johlju Quick reminder when you have a few minutes to check out the issue with the tests here :)
> I merged PR #79 so this one can be rebased. Thanks - I'll see if I can get the tests to resolve myself now, will keep you posted!
> Ping me when the tests passes on this one, I will try to get the time to review. 🙂 Thanks - doing some fairly major reworking of the rest...
@dan-hughes I think so - the pull still exists under #60. Do you think #85 will solve the problem I'm seeing in tests now, or is it another issue? (I...
Thanks @dan-hughes. That was what I feared, but didn't want to put the effort in if there was another cause. I'll do what I can to get it working, hope...
OK @dan-hughes I'm going to step off the CodeRabbit treadmill here and leave this with you until #86 is done now. I think I've got the unit tests related to...
> If you undo those changes and just keep this PR to the new resource then anything else can be swept up after. Ta, done!
@coderabbitai please be quiet
> @Borgquite, my PR's are merged. There will be some conflicts to deal with here. > > In this PR remove the changes to the Integration tests and Unit tests...