Borewit

Results 232 comments of Borewit

@lazka, can you help me out with some coding? ```Python self._RiffFile__fileobj.seek(self.__next_offset) self._RiffFile__fileobj.write(pack('

@lazka: Thanks! How to store metadata in RIFF/WAV files is not straight forward thing: Looks like there are two options (which can be combined): 1. Store metadata in the RIFF-LIST-INFO...

Since metadata in combination with RIFF/WAVE is known to be tricky, it was just to get a general understanding how other application deal with it. Especially the ID3v2 header is...

Did you try [Mp3Tag](https://www.mp3tag.de/) already?

> Sorry for asking but is there any ETA for #321 ? The short answer is no. In principle it is implemented and I would love to finish it, but...

Interesting idea @mooyoul. The way I read it, you propose 2 things: 1. Expand [file-type](https://github.com/sindresorhus/file-type) with custom "matchers" (code recognize file signature) 2. Split file-type engine from "matchers" (which requires...

I did not immediately understood what you meant with unsafe signatures, but I get it now, it are signatures beyond this point: https://github.com/sindresorhus/file-type/blob/c037ba7ed901bd5efe57bbba707b607035265eaf/core.js#L1179 these are much more likely to be...

I had a look to the MPEG-1 detection based on your feedback. https://github.com/sindresorhus/file-type/blob/c037ba7ed901bd5efe57bbba707b607035265eaf/core.js#L1181-L1189 > some of the unsafe file types does have more "safe" routes (like mpg). I don't think...

Related to unsafe types: https://github.com/Borewit/peek-readable/issues/356#issuecomment-902900156 pointing out is is also guessing the file-type here: https://github.com/sindresorhus/file-type/blob/c037ba7ed901bd5efe57bbba707b607035265eaf/core.js#L176-L180