Borewit

Results 226 comments of Borewit

> I dont believe the site has an updated build - it's the same error as earlier. I was convinced I merged the [music-metadata v10.8.2](https://github.com/Borewit/music-metadata/releases/tag/v10.8.2), but apparently not. Now it...

> Not sure if you folks are keeping the issue open for a specific reason, but tried the latest version of the library and Audio Tag Analyzer now and it...

Closing this PR as in favor of https://github.com/WhiskeySockets/Baileys/pull/1355, which avoids introducing the load-esm dependency.

@purpshell, I recommend to reopen this one, if you do not want change the TypeScript compiler module system to Node.js-aware ES module resolution. I moved the change to use parseFile...

> I don't see any readme update. My push failed, sorry about that.

> I Liked this approach. Any regression in the generated js files? The vast majority of the file remain unchanged, some changes in: - link-preview.js - messages-media.js Mostly that the...

- Rebased PR - Updated music-metadata to latest version - Updated PR description

Thanks for the review, I understand the concern about the tsconfig change. > I'm not sure about the proposed changes to the tsconfig. I'm sure there are some environments where...

> Yeah but I don't want to introduce things like loadEsm or the likes. For the time being, it is sufficient to use the outdated version as is. I understand...

> I am in the process of turning Baileys into ESM. The majority by a landslide wants it to be an ESM module. Thank you for your suggestions! I can...