kaggle_vol-3D-classify icon indicating copy to clipboard operation
kaggle_vol-3D-classify copied to clipboard

adding Dataset & dataModule

Open Borda opened this issue 3 years ago • 6 comments

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

extend handling data

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Borda avatar Aug 02 '22 22:08 Borda

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-08-04 13:09:47 UTC

pep8speaks avatar Aug 02 '22 22:08 pep8speaks

Codecov Report

Merging #5 (a507880) into main (51bf424) will decrease coverage by 14%. The diff coverage is 28%.

@@         Coverage Diff         @@
##           main    #5    +/-   ##
===================================
- Coverage    87%   72%   -14%     
===================================
  Files         5     7     +2     
  Lines       441   577   +136     
===================================
+ Hits        382   417    +35     
- Misses       59   160   +101     

codecov[bot] avatar Aug 02 '22 22:08 codecov[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This pull request introduces 4 alerts when merging 9e54cd66056cca9ef3ce5d8c9842fc9fa4ca4142 into 40b5498a6ed5da1a5dbf6cd428e6a47b9c893e2b - view on LGTM.com

new alerts:

  • 4 for Missing call to `__init__` during object initialization

lgtm-com[bot] avatar Aug 03 '22 10:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging 53ab5554cf18a3e6741c559f156953a74180ca78 into 51bf424cb26f2bf237cea78f64dba32c064346ae - view on LGTM.com

new alerts:

  • 4 for Missing call to `__init__` during object initialization

lgtm-com[bot] avatar Aug 03 '22 14:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging a5078804db4031e04dbc93a658f9d21d2da3d459 into 51bf424cb26f2bf237cea78f64dba32c064346ae - view on LGTM.com

new alerts:

  • 4 for Missing call to `__init__` during object initialization

lgtm-com[bot] avatar Aug 04 '22 13:08 lgtm-com[bot]