Jirka Borovec

Results 728 comments of Jirka Borovec

> LGTM, but it's gonna be a huge pain for people to handle merge conflicts :( Yeah, only other way is drop false hook with "formatting"

> I'm generally a fan of enforcing new style changes one by one as they change--is that possible here? @rbren Not sure what you mean, this is Black.

> can we avoid linting all files in this PR? This is a huge PR that will cause a lot of open PRs to have merge conflicts. Yes, we can,...

@li-boxuan @rbren dropped applied pre-commit but noted that the lining job will fail...

> I couldn't decide if I like this change or not. that is completely fine :) > I would just rename the `requires` folder to `requirements` to be more like...

Sure, there are several publications to do so. We refer a couple of them in "1.2 Other related methods" in [Region growing using superpixels with learned shape prior](https://www.researchgate.net/publication/321107546_Region_growing_using_superpixels_with_learned_shape_prior) some applications...

Friendly ping @klieret if you could have a look... :flamingo:

@klieret, I believe this could prevent many issues in future :)

friendly ping @alan-barzilay :chipmunk:

> friendly ping @alan-barzilay 🐿️ mind have a look, when you have time :flamingo: