BoostNote-Legacy icon indicating copy to clipboard operation
BoostNote-Legacy copied to clipboard

Add spell checker support

Open souhaiebtar opened this issue 8 years ago • 33 comments

souhaiebtar avatar Aug 08 '16 13:08 souhaiebtar

We're going to replace the current editor, Ace, with Codemirror. After replacing, we might be able to use codemirror-spell-checker . But, It is available only en-US now.

Rokt33r avatar Aug 11 '16 09:08 Rokt33r

Spellchecking API of chrome doesn't seem to be available yet. https://github.com/electron/electron/issues/3211

Rokt33r avatar Aug 11 '16 09:08 Rokt33r

I will close this because this issue has been left untouched.

kazup01 avatar Apr 17 '17 05:04 kazup01

Please could you reopen this - for me that's an essential missing feature. Thanks!

mhhennig avatar Jun 05 '17 08:06 mhhennig

Maybe you can add electron-spellchecker to editor?

beta-tank avatar Aug 29 '17 05:08 beta-tank

Would be nice as a toggleable setting! Not looking for an auto-correcting solution but highlighting misspellings would be very helpful

goldhand avatar Nov 13 '17 18:11 goldhand

This will help me as well. Any updates? Thanks!

Leiknir avatar Mar 10 '18 19:03 Leiknir

I too would like toggleable spellcheck. There are times when the squiggles would be distracting, like when taking notes live in a meeting. But, when drafting it's essential. Even an on-demand pass through aspell or similar would be better than nothing.

lylemoffitt avatar Apr 20 '18 15:04 lylemoffitt

This should be revisited–Spell check is a must when writing MD!

dbuskariol avatar Jun 09 '18 01:06 dbuskariol

I am working on it :). Though i will not promise anything..

ehhc avatar Jun 09 '18 10:06 ehhc

can you have a look at https://github.com/BoostIO/Boostnote/issues/2176 .. But it is not perfect..

ehhc avatar Jul 03 '18 15:07 ehhc

Hey guys, just a short update: the maintainer of boostnote and i do have a different view on the scope and the implementation of this feature. As i understood it, my PR will not be merged therefore. Sorry to say that but i can't do something about that feature anymore (and due to the huge amount of work i invested into my PR i feel a bit demotivated to try it again using the way the maintainer would like to have it. You can see a part of the discussion here: https://github.com/BoostIO/Boostnote/issues/2176 )

Sorry to let you down but i will not continue to work on it

ehhc avatar Sep 14 '18 09:09 ehhc

@kazup01 has started working. Visit this issue on Issuehunt

IssueHuntBot avatar Sep 25 '18 02:09 IssueHuntBot

@kazup01 has stopped working. Visit this issue on Issuehunt

IssueHuntBot avatar Sep 25 '18 02:09 IssueHuntBot

This needs to be a thing, I can't believe we're still talking about this. Mutiny?

lundyio avatar Nov 01 '18 14:11 lundyio

Has somebody of you tried the spellcheck that now exist? What do you think about it? Of course not perfect, but as a start point..?

ehhc avatar Jan 17 '19 16:01 ehhc

which version? is there any? I'm using 0.11.12 and can't find anything regarding this and dont see any functionality while editing.

mohamnag avatar Jan 17 '19 16:01 mohamnag

you have to enable it in the preferences. There is an option: Preferences > Editor > Enable spellcheck - Experimental feature!! :)

You have to enable it and should notice a spellcheck-dropdown under markdown notes

ehhc avatar Jan 17 '19 16:01 ehhc

since first time that I activated that check box, saving interface settings gives me the message "An error occured!" even though the settings are saved. this happens wether or not the checkbox is cleared.

as for the spell checking, seems to work except for some lag and corner cases. I would report back if I can reproduce them in a neutral env.

mohamnag avatar Jan 18 '19 09:01 mohamnag

@mohamnag thanks for the feedback. I have no idea why the error happens :( Yeah.. i know about the lags but don't know how to fix them.. i rely on a spellcheck-lib which i simply use..

ehhc avatar Jan 18 '19 10:01 ehhc

is there a way to get a low level log from application so that maybe helps with the error on saving the settings?

mohamnag avatar Jan 18 '19 10:01 mohamnag

@modmod24 Did you check devtool? And which OS are you using now?

Rokt33r avatar Jan 18 '19 13:01 Rokt33r

@Rokt33r you mean @mohamnag , don't you? :D

@mohamnag you can enable the developer console under View > Toggle Developer Tools... If there are any error messages / low level logs at all, you can find them there :)

ehhc avatar Jan 18 '19 14:01 ehhc

@Rokt33r the error happened to me while using boostnote on a Mac. I will report back more details when I'm back home but can't reproduce it right now on a Windows machine

mohamnag avatar Jan 21 '19 14:01 mohamnag

Related feature suggestion: #3171

Flexo013 avatar Jul 27 '19 00:07 Flexo013

@ehhc When I try to save the settings on Mac, I see the following:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

johnnyleitrim avatar Aug 02 '19 12:08 johnnyleitrim

@johnnyleitrim why do you think it's related to the spellcheck?

ehhc avatar Aug 02 '19 13:08 ehhc

@ehhc Sorry - I was under the impression you were looking for the logs when trying to save after clicking on spellcheck doesn't work.

you can enable the developer console under View > Toggle Developer Tools... If there are any error messages / low level logs at all, you can find them there :)

johnnyleitrim avatar Aug 02 '19 13:08 johnnyleitrim

@johnnyleitrim oh, okay. maybe i was back then :) thanks :)

I tried to reproduce your issue and - at least for me - it seams like it's only a warning and not preventing us from doing anything...

Do you also have issues with saving the preferences? Or did you just wondered about the warning?

ehhc avatar Aug 02 '19 14:08 ehhc

Any updates? From the comments, it looks like there was some form of functionality at some point, but I'm not seeing anything in the preferences at the moment. Possibly one of the features that has yet to be ported into the new version?

Pvanduyse avatar Oct 26 '20 22:10 Pvanduyse

I moved to MarkText, way better, way more functionality (including spell checking) and no forcing towards making profit out of it.

mohamnag avatar Oct 27 '20 07:10 mohamnag

@Pvanduyse If you're using boostnote (and not the new boostnote next - i don't know anything about that), you have to enable teh spellcheck in preferences: Preferences > Editor > Enable spellcheck - Experimental feature!! :)

After that there is a dropdown to select a language below the writting window

ehhc avatar Oct 27 '20 07:10 ehhc

I think this was disabled only to see if there where any performance issues. Perhaps default setting could be reconsidered. Many applications enable spell check per default.

arcturus140 avatar Oct 27 '20 20:10 arcturus140