BoostNote-Legacy icon indicating copy to clipboard operation
BoostNote-Legacy copied to clipboard

Can't delete notes

Open bestrocker221 opened this issue 5 years ago • 28 comments

Current behavior

I can't delete notes, neither with the trash icon, neither with the right click -> delete. Notes don't get deleted

Expected behavior

note delete

Steps to reproduce

try to delete a note

Environment

  • Version : 5.2.11-1-MANJARO
  • OS Version and name : Manjaro latest

bestrocker221 avatar Oct 11 '19 08:10 bestrocker221

What version of Boostnote are you using?

Flexo013 avatar Oct 11 '19 09:10 Flexo013

The last one at the time of writing.

Carlo Alberto

On Fri, 11 Oct 2019, 11:06 Flexo013, [email protected] wrote:

What version of Boostnote are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BoostIO/Boostnote/issues/3270?email_source=notifications&email_token=ACXQXIGNKIVZUJPIXKG4FJ3QOA6ZBA5CNFSM4I7W2UP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA7LZ6A#issuecomment-540982520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXQXICLWZ4VBOBXZPBWXSDQOA6ZBANCNFSM4I7W2UPQ .

bestrocker221 avatar Oct 12 '19 19:10 bestrocker221

Can anybody else with manjaro confirm this behavior?

Flexo013 avatar Oct 14 '19 14:10 Flexo013

@bestrocker221 Is this still an issue with 0.13.0?

Flexo013 avatar Oct 18 '19 20:10 Flexo013

Same issue

supanadit avatar Nov 19 '19 22:11 supanadit

@supanadit What OS are you on?

Flexo013 avatar Nov 20 '19 11:11 Flexo013

@ Flexo013 5.3.11-1-MANJARO, the worst case even i can't link the other boost directory

supanadit avatar Nov 20 '19 23:11 supanadit

Then I think it's safe to assume that this is a Manjaro only bug.

Flexo013 avatar Nov 21 '19 20:11 Flexo013

Same problem here with last version available (0.13.0), but on arch linux linux 5.4.2.arch1-1

kheraud avatar Dec 12 '19 11:12 kheraud

Same issue here on Arch Linux. I can't delete notes, or folders

dmouritsen avatar Jan 31 '20 17:01 dmouritsen

yeah, i think we agree that boostnote can't delete any notes in any linux operating system based on arch linux such as manjaro which i used.

supanadit avatar Feb 01 '20 09:02 supanadit

I can delete on my ArchLinux. Peek 2020-02-01 22-22

TheAifam5 avatar Feb 01 '20 21:02 TheAifam5

@supanadit @dmouritsen Could you provide a gif/video of what happens on your end?

@TheAifam5 What specific version of ArchLinux are you using?

Flexo013 avatar Feb 02 '20 22:02 Flexo013

@Flexo013 ArchLinux is rolling release distribution and does not have versions like Debian 9 or Ubuntu 18.10. It’s basically a Linux distro with always up-to-date packages, cutting-edge.

As far I know Manjaro is based on ArchLinux and if that’s a case, then my description above applies to it too.

Peoples that saying thing like “linux 5.4.2.arch1-1” is mostly an info about the kernel version, because like I said there is no version of the OS. I can’t be sure in case of Manjaro :)

TheAifam5 avatar Feb 03 '20 11:02 TheAifam5

Same here. Cannot delete or remove from the trash. The note stays in both the directory that I created it in and the trash.

image

charlwillia6 avatar Mar 06 '20 19:03 charlwillia6

If it's not the OS, then maybe it could be something problem with the path? Maybe an issue with space or other special characters.

@TheAifam5 @charlwillia6 @bestrocker221 @supanadit @dmouritsen @kheraud Could you post the full path to the storage you use?

Flexo013 avatar Mar 08 '20 15:03 Flexo013

Bump.

If nobody can help with further pinning down this issue, then we have no other option than to close this issue until more info is provided.

Flexo013 avatar Aug 10 '20 20:08 Flexo013

Same problem here.

System: Kernel: 5.4.64-1-MANJARO x86_64 bits: 64 compiler: gcc v: 10.2.0 Desktop: Xfce 4.14.2 Distro: Manjaro Linux

boostnote-bug

The same problem exists with the folders. Right clicking then "Delete folder" does not delete the folders. The only way to delete a folder is to go through "Preferences" and then click on the "Delete" button next to the folder name.

When I try to delete (whether it is a note in the trash or a folder) nothing happens. Nothing appears in the Developer Tools console either. On the other hand, by left clicking (to select it) on a note / a folder, these messages appear in the Developer Tools console:

main.js:211384 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

main.js:211384 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

I'm not sure it can help though ...

This issue is probably related to this https://github.com/BoostIO/Boostnote/issues/3520.

ArmandPhilippot avatar Sep 15 '20 13:09 ArmandPhilippot

I guess there are two different issues being reported here. One is for not being able to delete notes, and another for not being able to delete the folders. I have both issues... And I use Arch btw

I don't get any errors on dev tools nor the terminal. I'm happy to help with more info if you need it.

➤ lsb_release -a
LSB Version:	1.4
Distributor ID:	Arch
Description:	Arch Linux
Release:	rolling
Codename:	n/a

Installed via AUR

➤ pac list boostnote
local/boost-note-bin 0.9.0-1
    Boost Note.next, a replacement for Boostnote, an open source note-taking app for programmers.
    Official binary.
local/boostnote 0.16.1-1
    Open source note-taking app for programmers
➤ aur info boostnote
:: Querying AUR...
 -> Missing AUR Packages:  mplayer
Repository      : aur
Name            : boostnote
Keywords        : electron  productivity
Version         : 0.16.1-1
Description     : Open source note-taking app for programmers
URL             : https://boostnote.io/
AUR URL         : https://aur.archlinux.org/packages/boostnote
Groups          : None
Licenses        : GPL3
Provides        : None
Depends On      : electron  nodejs
Make Deps       : yarn  grunt-cli  git
Check Deps      : None
Optional Deps   : None
Conflicts With  : None
Maintainer      : clone1612
Votes           : 60
Popularity      : 0.989252
First Submitted : Mon 11 Apr 2016 09:01:00 AM EDT
Last Modified   : Sat 12 Sep 2020 04:13:16 AM EDT
Out-of-date     : No

victorbrca avatar Oct 14 '20 03:10 victorbrca

Something about the file paths on ArchLinux is causing this difference. If that is handled, then both issues will probably be resolved.

Flexo013 avatar Oct 24 '20 11:10 Flexo013

The difference is simple. There are two packages available, that provide this app on AUR (Arch User Repository)

  • https://aur.archlinux.org/packages/boostnote-bin/
    • Binary version, based on debian build, pretty much repackaged debian archive
  • https://aur.archlinux.org/packages/boostnote/
    • Built from source, with couple patches (such as removing analytics, etc), using system electron

The problem only happens with the version, which is built from source. So the issue is actually probably with the building process. Can someone from the BoostNote team please check, that the building process is correct and that the patches are not harmful to deleting functionality? Building happens in function build in this file, the patches you see mentioned in the function prepare are available here

otaj avatar Oct 29 '20 15:10 otaj

I don't know if this is something that @clone1612 would be able to help with. He's the maintainer for package in AUR.

victorbrca avatar Oct 29 '20 15:10 victorbrca

I suspect it might be related to the difference in Electron version being used (as otaj mentioned the regular boostnote package uses the system version). I’ll try to look into it this weekend.

clone1612 avatar Oct 30 '20 18:10 clone1612

It looks like it's actually using Electron 4:

➤ pac list boostnote
local/boostnote-bin 0.16.0-1
    Open source note-taking app for programmers. Official binary.
victor   3222699 3222646 15 15:36 ?        00:00:02 /usr/lib/boostnote/Boostnote --type=renderer --no-sandbox --enable-features=SharedArrayBuffer --service-pipe-token=8757413579444629136 --lang=en-US --app-path=/usr/lib/boostnote/resources/app --user-agent=Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Boostnote/0.16.0 Chrome/69.0.3497.128 Electron/4.2.12 Safari/537.36 --node-integration=true --webview-tag=true --no-sandbox --background-color=#fff --enable-blink-features=OverlayScrollbars --num-raster-threads=4 --enable-main-frame-before-activation --service-request-channel-token=8757413579444629136 --renderer-client-id=4 --shared-files=v8_context_snapshot_data:100,v8_natives_data:101

I tried to build electron4 on my other machine so I could compare/test but it keeps failing.

victorbrca avatar Oct 30 '20 19:10 victorbrca

I've updated the package build from source (i.e. https://aur.archlinux.org/packages/boostnote/) to now use Electron 4.

Tested delete/restore and the electron downgrade seems to resolve the issues, please update the package (latest version is boostnote 0.16.1-4) and let me know if that also fixes the issues on your end.

clone1612 avatar Oct 31 '20 09:10 clone1612

Thanks! I just did the update and deleting notes / folders is working.

ArmandPhilippot avatar Oct 31 '20 10:10 ArmandPhilippot

Can also confirm, that with electron4 it works. It would be however nice for boostnote developers to have more recent version. The reasons are simple :

  1. so that we don't need to have different electron binary for different application (I currently have three electron apps, BoostNote, Ferdi and VSCode and each uses different electron package)
  2. and to have bugs of older versions fixed.

otaj avatar Oct 31 '20 18:10 otaj

Using one electron will break a lot of things, mostly native node modules but also in some cases API.

Sorry for offtopic.

TheAifam5 avatar Oct 31 '20 20:10 TheAifam5