Website icon indicating copy to clipboard operation
Website copied to clipboard

Find new Issues

Open RohitKumar-200 opened this issue 3 years ago • 24 comments

Check out our website https://bookshlf.web.app.

Find bugs in it, Add new features, improve UI/UX, or anything else. Discuss it here(or create a new issue), and create PR referencing the issue.

RohitKumar-200 avatar Oct 13 '21 21:10 RohitKumar-200

Check out our website https://bookshlf.web.app.

Find bugs in it, discuss it here(or create a new issue), and create PR referencing the issue.

I have a suggestion for signup. When the user signs up on the site he/she is asked to verify his/her email id which is good but when he enter OTP and verify it he/she is again redirected to login page and again he/she have to enter his/her email and pass. I think it will be easier for the user if he/she is automatically logged in after OTP verification.

rockingrohit9639 avatar Oct 14 '21 04:10 rockingrohit9639

Check out our website https://bookshlf.web.app. Find bugs in it, discuss it here(or create a new issue), and create PR referencing the issue.

I have a suggestion for signup. When the user signs up on the site he/she is asked to verify his/her email id which is good but when he enter OTP and verify it he/she is again redirected to login page and again he/she have to enter his/her email and pass. I think it will be easier for the user if he/she is automatically logged in after OTP verification.

@rockingrohit9639 This is a normal authentication process in any website. I don't think it is a good idea to directly log in after signUp. @Mrhb787 what are your thoughts on this?

RohitKumar-200 avatar Oct 14 '21 04:10 RohitKumar-200

There is a small problem for the smallest screen on Profile page: avatar covers user's information. Screenshot 2021-10-15 at 15 21 15

Neniya avatar Oct 15 '21 13:10 Neniya

There is a small problem for the smallest screen on Profile page: avatar covers user's information. Screenshot 2021-10-15 at 15 21 15

@Neniya do you want to take up this issue?

RohitKumar-200 avatar Oct 15 '21 19:10 RohitKumar-200

@RohitKumar-200 Unfortunately, I'll not be available for the next two weeks. In case it is somehow urgent, please feel free to assign it to somebody else. Otherwise I can take a look, once I'm back. Thank you.

Neniya avatar Oct 16 '21 09:10 Neniya

when I click on the more button it is not working. kindly check it out

bhumithakur avatar Oct 19 '21 14:10 bhumithakur

when I click on the more button it is not working. kindly check it out

@bhumithakur More button is working fine. As no. of books are less, it seems that button is not working. I have added more books, you can check it now.

RohitKumar-200 avatar Oct 19 '21 20:10 RohitKumar-200

Best selling books on the homepage is not clickable. For example, On clicking 'Test your C skills',page should redirect to the book-details page of that book.

I would like to work on this if it's valid issue.

best_selling_books

On clicking it will redirect to its details page ->

book details

AnimeshMore avatar Oct 20 '21 12:10 AnimeshMore

@AnimeshMore I have created this issue please feel free to work on It

Mrhb787 avatar Oct 20 '21 13:10 Mrhb787

I know that when I was working on issue #49, the available quantity was decreasing when the customer had increased the purchasing quantity of the given book. In the current update however this stopped working for some reason.

Example:

image Pic. 1: Available quantity: 25, Purchasing quantity: 1.

image Pic. 2: Purchasing quantity was increased by 1. So the displayed output should be: Available quantity: 24, Purchasing quantity: 2. However, actual display output shows: Available quantity: 25, Purchasing quantity: 2.

AngelicHeaven avatar Oct 22 '21 10:10 AngelicHeaven

@AngelicHeaven Until the order is not confirmed available Quantity can not be changed because if multiple users are having same item in cart but not purchasing then it will show 0 available quantity however it is present.

Mrhb787 avatar Oct 22 '21 13:10 Mrhb787

@Mrhb787 I get it now. Thanks for the explanation.

AngelicHeaven avatar Oct 22 '21 13:10 AngelicHeaven

@Mrhb787 hello I would like to ask if this project uses any CI technology? :) thank you.

AngelicHeaven avatar Dec 13 '21 19:12 AngelicHeaven

@AngelicHeaven No. Currently this project doesn't have any kind of automated tests. So, using CI/CD can result in worst outcomes. We manually do it to avoid bugs.

RohitKumar-200 avatar Dec 14 '21 09:12 RohitKumar-200

Signup page is not working

MerguRajesh123 avatar Mar 31 '22 10:03 MerguRajesh123

@MerguRajesh123 Please describe the issue in brief. Show some screenshots or tell us how to recreate that issue.

RohitKumar-200 avatar Mar 31 '22 13:03 RohitKumar-200

When iam registering with user details it shows error like Uploading IMG20220331185953.jpg…

MerguRajesh123 avatar Mar 31 '22 13:03 MerguRajesh123

@RohitKumar-200 signup page is not working when iam register with user details it shows error like 1.POST http://localhost:3000/signUp 504 xhr.js:187(Not Found) 2.Uncaught (in promise) TypeError : Cannot read properties of undefined(reading 'length') at handelSignupErrors(signup.js:143:1) at Signup.js:122:1

MerguRajesh123 avatar Mar 31 '22 13:03 MerguRajesh123

Uploading IMG20220331185953.jpg…

MerguRajesh123 avatar Mar 31 '22 13:03 MerguRajesh123

Signup page is not working when i took this code run in my vscode the signup page error is showing while registering.

kalyan-achyuta avatar Mar 31 '22 13:03 kalyan-achyuta

@MerguRajesh123 You are facing signUp issue in localhost, not in hosted website.

Confirm that you have read README.md and set up your project as described there. I think that you have missed that .env setup. You have to create a .env file and put the following content there

REACT_APP_BOOKSHLF=https://bookshlf.herokuapp.com/
REACT_APP_NODE_ENV=development

Also I am not able to see the screenshot that you are uploading here. Please reupload it.

RohitKumar-200 avatar Mar 31 '22 13:03 RohitKumar-200

@RohitKumar-200 when I try to add book it shows approval pending how can I add

MerguRajesh123 avatar Apr 01 '22 06:04 MerguRajesh123

@MerguRajesh123 @kalyan-achyuta Is your signup problem resolved now?

RohitKumar-200 avatar Apr 01 '22 12:04 RohitKumar-200

@MerguRajesh123 When the admin approves the book, then you can see that book in search results.

Currently, you are using our hosted backend API, therefore I am the admin there. I have approved the book. If you want your own backend and database, you can refer to the Backend repo and set up your own backend.

RohitKumar-200 avatar Apr 01 '22 12:04 RohitKumar-200