BookStack
BookStack copied to clipboard
Wrong notification preferences URL in email
Describe the Bug
The notification preferences URL in the email points to a 404 page.
In the mail: bookstack.example.com/preferences/notifications On the website: bookstack.example.com/my-account/notifications
Steps to Reproduce
- Watch a book.
- Modify book (with other user).
- Receive notification mail.
- Mail contains wrong link to the notifications settings: /preferences/notifications
Expected Behaviour
Proper link in the mail: /my-account/notifications
Screenshots or Additional Context
https://github.com/BookStackApp/BookStack/blob/a3a776d4a6d3a4d8d79c2a27a0e89dd929bd8b14/app/Activity/Notifications/Messages/BaseActivityNotification.php#L46
https://github.com/BookStackApp/BookStack/blob/a3a776d4a6d3a4d8d79c2a27a0e89dd929bd8b14/routes/web.php#L245C93-L245C112
Browser Details
No response
Exact BookStack Version
v24.05
Thanks for reporting @kroomagnon, I've assigned this for the next patch release.
Resolved by @KiDxS via https://github.com/BookStackApp/BookStack/pull/5008, to be part of next patch release.