BookStack icon indicating copy to clipboard operation
BookStack copied to clipboard

Support nested levels/use of content include tags

Open sid3windr opened this issue 3 years ago • 3 comments

Describe the bug Multiple layers of page inclusion are not being evaluated correctly.

Steps To Reproduce Steps to reproduce the behavior:

  1. Create page A with some content.
  2. Create page B with some content, and include page A in it. This will display correctly.
  3. Create page C with some content, and include page B in it.
  4. Page C will have the page C content from step 3, and the page B content from step 2, followed by the {{@123}} inclusion tag for page A, instead of page A's content.

Expected behavior All pages to be included should be displayed correctly.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): 21.04
  • PHP Version: 7.3.29
  • Hosting Method (Nginx/Apache/Docker): Apache

sid3windr avatar Jul 14 '21 12:07 sid3windr

Related to #1601

ssddanbrown avatar Jul 14 '21 12:07 ssddanbrown

+1 for this feature

robertfshort avatar Feb 24 '22 15:02 robertfshort

+1 for this

JoeIzzard avatar Aug 24 '22 11:08 JoeIzzard

+1 for this feature

jasonF1000 avatar Mar 27 '23 10:03 jasonF1000

+1 for this feature

deleyva avatar Mar 30 '23 10:03 deleyva

Hi,

i think a depth of 3 layers for the page inclusion should be enoght for the most cases. Is there any implementation Plan in the near Future for this Feature?

Regards, jason

jasonF1000 avatar Apr 11 '23 09:04 jasonF1000

Up to three levels of nested has now been added within the work of PR #4192, thanks to @jasonF1000. Will be part of the next feature release.

ssddanbrown avatar Apr 27 '23 14:04 ssddanbrown