BookStack icon indicating copy to clipboard operation
BookStack copied to clipboard

Mac Editor Shortcuts in Safari

Open digitall-it opened this issue 4 years ago • 6 comments

Cmd+1...9 shortcuts are already assigned to swap tabs in Safari for Mac, so they will not work to change headers in the editor. They should be changed to another key combination.

digitall-it avatar Feb 20 '21 18:02 digitall-it

Thanks for raising @digitall-it, I don't often use mac myself, do you have any suggestions for these shortcuts that won't conflict with existing mac/safari shortcuts?

ssddanbrown avatar Feb 20 '21 19:02 ssddanbrown

I will check out if other JavaScript editors out there use a de facto standard and report within 24 hours.

digitall-it avatar Feb 20 '21 20:02 digitall-it

After revising this document and this document I suggest Ctrl-Option-1..9. Also, I would like to thank you for providing support on such a wonderful project. I have some feature requests that I'll file in separate issues.

digitall-it avatar Feb 21 '21 13:02 digitall-it

Any chance a PR would be accepted for this change? Can't imagine it would be too risky without you having a Mac to review.

mlschuh avatar Dec 08 '23 15:12 mlschuh

@mlschuh I'd be happy to accept a PR, although the following will need to be considered:

  • This should be aligned across both editors (Markdown and WYSIWYG).
  • If the existing shortcuts work on other browsers for Mac, I'd want to keep those also to prevent breaking change for those users.
  • The editor help view would also need to be updated since we show shortcuts there.
    • The website docs would need to be updated, but I'm happy to flag this then make those changes when readying the next release.

ssddanbrown avatar Dec 08 '23 15:12 ssddanbrown

@ssddanbrown I tested Safari, Chrome and firefox. The behaviour is in all 3 the same, with command+1-9 you switch between your open tabs. In safari it is possible to chance the shortcut, than you open your first 3 favourites. So I think it is necessary to do an update otherwise you always need to use your mouse.

D7design avatar May 10 '24 15:05 D7design