Web3.swift icon indicating copy to clipboard operation
Web3.swift copied to clipboard

Change Web3HttpProvider init to use URL

Open brettfazio opened this issue 4 years ago • 2 comments

Change the String in the init to URL and thus it removes the possible error during unwrapping (the URL now has to be unwrapped by the user beforehand).

Also changed a test as it was taking in a String.

brettfazio avatar Jan 30 '21 15:01 brettfazio

@koraykoska seems like this same CI failure is on every PR.

brettfazio avatar Feb 01 '21 16:02 brettfazio

The reason I set it to a random URL if it fails to unwrap is that if it fails to unwrap all calls to this object (should) fail anyway. Ideally, people should probably use the init with the URL not the String.

brettfazio avatar Feb 04 '21 00:02 brettfazio