Web3.swift icon indicating copy to clipboard operation
Web3.swift copied to clipboard

DynamicContractTests never run all tests

Open koraykoska opened this issue 7 years ago • 1 comments

The DynamicContractTests always stop creating tests because of this line.

contract.deploy somehow always fails and because we just return there. We don't even notice when running the test suite.

I think the deploy fails because there is no constructor function in the ERC721.json stub.

@pixelmatrix How was this meant to be tested?

koraykoska avatar Aug 22 '18 11:08 koraykoska

Hmm, that's a good catch! Looks like a simple mistake. Perhaps this was supposed to use another stub? I can submit a fix for this.

pixelmatrix avatar Aug 22 '18 18:08 pixelmatrix