racket-review icon indicating copy to clipboard operation
racket-review copied to clipboard

Checking for unused requires?

Open jackfirth opened this issue 6 years ago • 5 comments

Can this also check for unnecessarily required modules?

jackfirth avatar Dec 04 '19 20:12 jackfirth

I would like it to, but I think that might require expanding the required modules, which would be slow without some caching mechanism (also not ideal). I'll look into it, though!

Bogdanp avatar Dec 05 '19 07:12 Bogdanp

A couple semi-random things:

  • Someday/maybe you could tag some checks to run only in a "slower but more thorough mode". People might not want to use that slow/thorough mode in e.g. flycheck, but might want to use it as part of a make test run locally and/or on CI.

  • In the "prior work" part of the README it might make sense to list Jack's syntax-warn?

greghendershott avatar Dec 05 '19 15:12 greghendershott

I'd also be happy to link to this project from syntax-warn.

jackfirth avatar Dec 05 '19 21:12 jackfirth

Someday/maybe you could tag some checks to run only in a "slower but more thorough mode". People might not want to use that slow/thorough mode in e.g. flycheck, but might want to use it as part of a make test run locally and/or on CI.

I like that idea, thanks!

In the "prior work" part of the README it might make sense to list Jack's syntax-warn?

Added! I think I saw @jackfirth mention it in one of his RacketCon talks, but then I completely forgot about it so thank you for the reminder.

Bogdanp avatar Dec 06 '19 08:12 Bogdanp

Added a link to this from syntax-warn!

jackfirth avatar Dec 07 '19 05:12 jackfirth