MagicDance icon indicating copy to clipboard operation
MagicDance copied to clipboard

the code of computing PSNR in the Disco repository is wrong

Open Delicious-Bitter-Melon opened this issue 5 months ago • 2 comments

The Disco code of computing PSNR as follows is wrong: https://github.com/Wangt-CN/DisCo/blob/8538889c9ee9edd8dd43ffee182d1a91ce7a9828/tool/metrics/ssim_l1_lpips_psnr.py#L13.

image

As pointed out in https://github.com/Wangt-CN/DisCo/issues/86, the accurate code is mse = np.mean((original/1.0 - compressed/1.0) ** 2) instead of mse = np.mean((original - compressed) ** 2) , because original and compressed images are uint8 in their code, and (original - compressed) * * 2 will cause numerical overflow.

If you use their evaluation code of computing PSNR, please update your results.

Delicious-Bitter-Melon avatar Mar 25 '24 11:03 Delicious-Bitter-Melon