Yuan (Bob) Gong
Yuan (Bob) Gong
> then Find does rootDir, err = filepath.Abs(rootDir), nil turns into working directory (root package folder) This seems unexpected, can we infer a vendor dir and set a correct root...
There were some special handling for vendored packages in https://github.com/google/go-licenses/blob/5eedde1c65841c2733460b0ae2f1a32e6eb164fb/licenses/library.go#L152 You might consider doing a similar check and infer root path of package.
The title should probably be chore, because this does not affect user feature.
I agree there are many special terms, but maybe it's not a huge problem, because they are only internal terms -- KFP users do not need to understand them. My...
Another thought, maybe it's better to name this new CLI kfpexec? The name comes from argoexec. If people inspect KFP v2 underlying Pods, they'll easily find argoexec and also kfpexec...
/assign @kubeflow/aws
I noticed that e2e test failed, because it also uses v1 legacy sample test code to run some basic samples, so we cannot merge this PR yet.
/hold blocked by https://github.com/kubeflow/pipelines/issues/7120
Part of https://github.com/kubeflow/pipelines/issues/4682 This is a dashboard provided by renovate-bot, maintainers can check the marks above to let the bot create certain update PRs.
Cleaning up MLMD entries requires upstream feature request: https://github.com/google/ml-metadata/issues/69