Bobby McDonald comments

Results 91 comments of


                                            Bobby McDonald

Probably need to rename this

Someone beat you to the joke by 4 years :( Do you need some TLRPC?

`Rack::Builder#to_app` is not designed to be called for every request.

Thanks for the report, this is an area of the library I haven't looked much into. Would memoizing the to_app call be sufficient?

`Rack::Builder#to_app` is not designed to be called for every request.

I'm not opposed to a major bump if need be, so the change can be as breaking as needed

`Rack::Builder#to_app` is not designed to be called for every request.

I think the biggest downstream consumer is devise, so we'd wanna look if/how devise uses the builder and try and at least keep backwards compatibility for that

`Rack::Builder#to_app` is not designed to be called for every request.

Thanks @speckins I will take a look as soon as I have some time, I've been very busy

Provide option to configure format of branch name

You could always monkey-patch it, now whether or not you _should_... ```ruby module Dependabot class PullRequestCreator class BranchNamer def new_branch_name super.gsub(TO_REMOVE, TO_REPLACE) end end end end ```

Private hex repo support

Thanks @sorentwo! Glad to see this being handled 🙂

Private hex repo support

I haven't been actively working in Elixir for a while, and I don't have access to a project w/ oban_pro anymore, but here's some thoughts from cursory research I had...

Unclear how to add automated test ensuring that Periodic Jobs configuration can be processed

@f1sherman We only enable certain crons in prod, so we had issues similar. Similar to the wiki guide, we have a class ```ruby class PeriodicJobsRegistration def self.call(mgr) # ... mgr.register('0...

When Timecop enabled, Date parse with year and week returns wrong date (a year before)

We have also experienced this issue.