Robert Means comments

Results 101 comments of


                                            Robert Means

Update sanitize-html from 2.1.0 to 2.12.1 fails. Module parse failed: Unexpected token.

Can you provide better steps to replicate the error? Again, there isn't a build script.

Update sanitize-html from 2.1.0 to 2.12.1 fails. Module parse failed: Unexpected token.

Thanks @Insomniak313! - I thought it was something with the version of htmlparser2.

Improving ApostropheCMS Performance with High Request Volumes and Large JSON Payloads

Hi @maamounkhlifi - Did you manage to solve this issue? Is there any other assistance we can give, or can I close this?

Copy paste error in login module for "uponSubmit" requirements

Thanks for this report!

Copy paste error in login module for "uponSubmit" requirements

This PR has landed and will be in the next release - early October.

`<hello` return `` when escaping content

I think your test case is incomplete. What HTML are we sanitizing?

`<hello` return `` when escaping content

Taking a quick look at the code, I think the problem stems from the newer `onclosetag` handler and how html-parser2 handles malformed tags. I think it treats the `

linear-gradient in background style property seems to breaks the whole property

@srenoufd - would you mind writing a small (failing) test for this so that we can see the issue more clearly?

linear-gradient in background style property seems to breaks the whole property

@srenoufd - Thanks for doing that!! You could have just added the test here in the issue, but it did allow me to see the issue are having a little...

linear-gradient in background style property seems to breaks the whole property

It is up to you how stringent you want to be with the sanitization, so that regex would be fine.