framework
framework copied to clipboard
fix: docker extension removal
I added a flag because exporting in the docker container is not available.
$ docker compose exec panel export USER_CONFIRMED_REMOVAL="yes"
OCI runtime exec failed: exec failed: unable to start container process: exec: "export": executable file not found in $PATH: unknown
it is not found in /bin there should be a path /bin/export that should be there to export env, but there is not that's why it fails.
via using this docker image: https://github.com/BlueprintFramework/docker/blob/Master/docker-compose.yml
I also mentioned this in the discord I was told by @prplwtf there will be a flag implemented soon, but I need this asap so here is the pr. Link to message
Flag aside, you can set environmental variables in a Docker container exec command: https://docs.docker.com/reference/cli/docker/container/exec/#env
I highly doubt this will parse correctly. The
-user-confirmed-removalflag will also be parsed as an extension removal task and will always need to be the second argument.
blueprint -r example -user-confirmed-removalRemoves example, attempts removal on-user-confirmed-removalwhich does not exist Does not ask for confirmation
blueprint -r example example2 -user-confirmed-removalRemoves example, removes example2, attempts removal on-user-confirmed-removalwhich does not exist Asks for confirmation
blueprint -r example -user-confirmed-removal example2Removes example, attempts removal on-user-confirmed-removalwhich does not exist, removes example2 Does not ask for confirmationWe currently do not have a standard way of parsing arguments to
-remove,-installor any command for that matter.
They never tested what they wrote in general because they didn't know how to build the panel
@laraproto :shrug:
I am closing this pr the alternative is docs.docker.com/reference/cli/docker/container/exec#env