YoutubeDLSharp icon indicating copy to clipboard operation
YoutubeDLSharp copied to clipboard

Add a second "RunWithOptions" Method that returns the standard RunResult<string> and accepts IProgress parameters

Open adanvdo opened this issue 2 years ago • 1 comments

I was needing to do some post-processing on audio-only formats and the RunAudioDownload method was not able to do what I needed. RunWithOptions was able to do it, but I ran into a couple things that were problematic in my project.

  • RunWithOptions did not accept the standard string url param the other download methods do
  • It did not accept the Progress or Output IProgress params.
  • It did not return a clean Download Location

This change implements a second RunWithOptions method that accepts the standard parameters used by the other download methods and returns a clean Download Location.

adanvdo avatar Jun 22 '22 14:06 adanvdo

Hey @adanvdo, thanks for opening this PR and sorry for the long response time. Your description of the changes sound reasonable and I'm happy to merge that. However, it seems you added further changes to this branch in the meantime. Would be great if you could disentangle the originally described changes so I can merge those first.

Of course I'm also happy to merge further changes from your side back to this repo afterwards (hopefully with a shorter review and merge time).

alxnull avatar Aug 21 '22 21:08 alxnull