cvu icon indicating copy to clipboard operation
cvu copied to clipboard

Fix interface for stability and consistency

Open alanturing-bluemirrors opened this issue 1 year ago • 1 comments

This PR is to apply changes to the current interface based on the issues or misconfigurations identified during development.

Identified issues:

  • init() method in ICore accepts parameters classes which is biased to object detection and doesn't have application in other use cases such as: Image Text Matching (no classes to process), Background removal (no classes to process), etc.

Steps to regain control of the interface:

  • Fixing the ICore interface: Remove the parameter classes as it has minimal use in the interface. Re-arrange the interface call from the init() method in Yolov5 core to ensure consistency with development.

Tests performed:

  • Evaluated the branch once the changes were published, ran a benchmark script to test the functionality. It doesn't seem to break the code. (Preliminary test)

DO NOT MERGE THE PR UNTIL THE THREE MAINTAINERS HAVE VERIFIED AND APPROVED THE CHANGES

alanturing-bluemirrors avatar Jul 29 '22 23:07 alanturing-bluemirrors

@alanturing-bluemirrors @mavihs7 are you guys still working on this ? This looks good to me. thanks for putting this together

makaveli10 avatar Nov 01 '22 11:11 makaveli10