cliclick icon indicating copy to clipboard operation
cliclick copied to clipboard

use ScreenCaptureKit and add the "sl" command for scrolling

Open mohsen1 opened this issue 1 year ago • 3 comments

This pull request brings some updates and improvements to the current branch. We've made changes to various action classes to enhance functionality and performance.

One thing to note is that the current setup doesn't work with iPhone Mirroring. I am looking for advice on how to tackle this issue, so any suggestions would be appreciated.

The changes have been tested on macOS, and everything seems to be working fine under normal conditions. Please take a look at the updates and let us know your thoughts. Your feedback is important to us to ensure the application is robust and reliable.

#22 #10

mohsen1 avatar Nov 01 '24 15:11 mohsen1

I applied this patch and was able to compile this (with some warnings, attached). It seems to work just fine.

$ uname -a
Darwin m2otter.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:11 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6020 arm64

cliclick-warnings.txt

briandfoy avatar Feb 21 '25 07:02 briandfoy

This looks like a great addition. Would love to see it merged in some capacity!

jamesdh avatar May 26 '25 16:05 jamesdh

Thanks @mohsen1 for fixing #178 by using ScreenCaptureKit. I pulled your specific fix lines in Actions/ColorPickerAction.m into a separate PR #192 that does not include your sl command.

justinpearson avatar Jun 20 '25 13:06 justinpearson

Just a note that my PR https://github.com/BlueM/cliclick/pull/192 is not yet merged. I at-mentioned the author but no response yet.

justinpearson avatar Jul 14 '25 15:07 justinpearson