bluebubbles-app icon indicating copy to clipboard operation
bluebubbles-app copied to clipboard

Published 20 hours ago • verified publisher icon BlueBubblesApp

Play Send Sound Setting

Open jakeump opened this issue 3 years ago • 9 comments

  • Custom send and receive sound on mobile and web
  • https://github.com/BlueBubblesApp/bluebubbles-app/issues/524

Due to some issues with Git, this took a while to get right.

jakeump avatar Aug 18 '22 07:08 jakeump

Did you add the default iMessage sound? I don't see it in the assets in your PR

tneotia avatar Aug 18 '22 14:08 tneotia

Also, file paths for app data should use the application support directory on desktop.

jjoelj avatar Aug 18 '22 14:08 jjoelj

@tneotia I had originally done that, but was told it's not a good idea due to copyright. Thus, I have only enabled custom sounds–no defaults.

I will look into how to use the application support directory

jakeump avatar Aug 19 '22 06:08 jakeump

Sounds good, your OP had said plays default sound so I was just curious

tneotia avatar Aug 19 '22 14:08 tneotia

Sounds good, your OP had said plays default sound so I was just curious

Oh yeah that was just copy-pasted from my original PR and I didn't bother to read it 🤦‍♂️

jakeump avatar Aug 19 '22 14:08 jakeump

@jakeump so is this good to go? probably can get it into our v1.11.0 release

zlshames avatar Aug 26 '22 00:08 zlshames

@jakeump just checking back in on this. Let me know what the status of this is. Thanks!

zlshames avatar Sep 10 '22 15:09 zlshames

@jakeump just checking back in on this. Let me know what the status of this is. Thanks!

Hey Zach, sorry I've been putting this off a bit. I've been really busy with school and interviews recently. I'll try to get this finished by next weekend

jakeump avatar Sep 10 '22 15:09 jakeump

@jakeump just checking back in on this. Let me know what the status of this is. Thanks!

Hey Zach, sorry I've been putting this off a bit. I've been really busy with school and interviews recently. I'll try to get this finished by next weekend

Hey, no real rush on this. Take it at your own pace. I was just pinging because I didn't get a response from you from my last message

zlshames avatar Sep 10 '22 15:09 zlshames

Hi @jakeump I went ahead and cherry-picked and updated your commit, this should make its way into v1.11 Beta 3. You should still get credit for it, GitHub shows as co-authored. Thanks for this!

tneotia avatar Jan 14 '23 19:01 tneotia

Hi @jakeump I went ahead and cherry-picked and updated your commit, this should make its way into v1.11 Beta 3. You should still get credit for it, GitHub shows as co-authored. Thanks for this!

Hey I'm sorry I couldn't get this done, school has been pretty time-consuming and I didn't have flutter setup on my laptop. Appreciate you picking up my slack

jakeump avatar Jan 14 '23 19:01 jakeump