bluebubbles-app icon indicating copy to clipboard operation
bluebubbles-app copied to clipboard

Chats from branded SMS show empty display names

Open 13lievre opened this issue 3 years ago • 4 comments

Chats from branded SMS show empty display names.

Here's link for info about branded sms: https://www.smsapi.com/blog/sender-id-how-to-send-branded-sms-company-name/

13lievre avatar Jun 08 '22 09:06 13lievre

image

13lievre avatar Jun 08 '22 09:06 13lievre

Technically these chats should be ignored when initially syncing... I guess if this was a new message then it wasn't properly ignored. @zlshames what should we do about this?

tneotia avatar Jun 08 '22 13:06 tneotia

Spoke to Joel about this in a discord chat. He just wanted me to post it here as well.

13lievre avatar Jun 08 '22 13:06 13lievre

@tneotia I actually un-excluded the urn: chats from the chat query endpoint. For the same reason I include the archived chats by default now. Might as well show them, so long as the client can handle them. So I'm guessing that's the reason.

Prior, we excluded them because they caused the sync to break. It was hard to reproduce because we didn't have any urn chats ourselves

zlshames avatar Jun 08 '22 13:06 zlshames

Added better support - we cant show the business name but it wont be empty anymore

tneotia avatar Nov 29 '22 16:11 tneotia