BlueBubbles-Desktop-App icon indicating copy to clipboard operation
BlueBubbles-Desktop-App copied to clipboard

Improve accessibility by making conversations tabbable

Open jpribyl opened this issue 3 years ago • 0 comments

These blocks of code contain interactive elements that are not given interactive tags or tabindex. This means that it is not possible to tab through the "compose new message" button or the conversation list.

https://github.com/BlueBubblesApp/BlueBubbles-Desktop-App/blob/47bbd562ba979fdf1fca0eaab3faefaa9f06e093/src/renderer/components/ViewContainer/MessagingView/LeftCol/TopNav/LeftTopNav.tsx#L58-L81

https://github.com/BlueBubblesApp/BlueBubbles-Desktop-App/blob/47bbd562ba979fdf1fca0eaab3faefaa9f06e093/src/renderer/components/ViewContainer/MessagingView/LeftCol/ConversationsNav/Conversation/Conversation.tsx#L139-L178

The fix (which I will PR if y'all are interested) is to pass props into the components with tabIndex="0" (see here https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)

jpribyl avatar Oct 23 '21 19:10 jpribyl