nmodl icon indicating copy to clipboard operation
nmodl copied to clipboard
verified publisher icon BlueBrain

Use aligned_alloc as we do in CoreNEURON too

Open ohm314 opened this issue 3 years ago • 13 comments

also updated header includes

ohm314 avatar Sep 19 '22 08:09 ohm314

Logfiles from GitLab pipeline #74797 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Sep 19 '22 09:09 bbpbuildbot

Actually, let's check the issue with the change of headers requiring explicit namespaces first. Also, using here aligned_alloc will put restrictions on buffer sizes, which we should also handle here (as we did in CoreNEURON).

ohm314 avatar Sep 19 '22 12:09 ohm314

Logfiles from GitLab pipeline #74856 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Sep 19 '22 14:09 bbpbuildbot

Noticed a performance degradation in our nightly benchmarks, so let's not merge yet

ohm314 avatar Sep 20 '22 09:09 ohm314

decided to drop this since perf is impacted negatively.

ohm314 avatar Sep 26 '22 13:09 ohm314

After the back-and-forth on coreneuron where we finally saw that the performance regression was unrelated to the newly introduced aligned_alloc, I thought I run once more with the replacement here and it looks good:

image

So, I'm reopening this.

ohm314 avatar Oct 11 '22 12:10 ohm314

Logfiles from GitLab pipeline #78121 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Oct 11 '22 13:10 bbpbuildbot

@ohm314 - what was last verdict on this part?

pramodk avatar Jan 12 '23 10:01 pramodk

@ohm314 do you want to resolve the conflicts and then review/merge; or do we close this?

1uc avatar May 10 '24 12:05 1uc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.59%. Comparing base (7984a45) to head (de64a8e). Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files         182      182           
  Lines       13552    13552           
=======================================
  Hits        11735    11735           
  Misses       1817     1817

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 16 '24 09:05 codecov-commenter

Logfiles from GitLab pipeline #211452 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar May 16 '24 09:05 bbpbuildbot

Logfiles from GitLab pipeline #211467 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar May 16 '24 11:05 bbpbuildbot

Logfiles from GitLab pipeline #211494 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar May 16 '24 12:05 bbpbuildbot

Logfiles from GitLab pipeline #228935 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Aug 29 '24 13:08 bbpbuildbot

Logfiles from GitLab pipeline #228934 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Aug 29 '24 13:08 bbpbuildbot

Logfiles from GitLab pipeline #228951 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Aug 29 '24 14:08 bbpbuildbot