nmodl icon indicating copy to clipboard operation
nmodl copied to clipboard

Remove pointless macros from `crout.hpp`

Open 1uc opened this issue 1 year ago • 0 comments

The naming conventions in solveCrout need fixing. y isn't a good name for a pivot vector, p is more canonical, but p is something completely different, unless it's used through the macro y_[i] (which is p[y[i]]).

The the blocks of code are completely duplicated and can be trivially be deduplicated using a sensible abstraction for y_.

The second copy of the comments is incorrect/misleading about y.

1uc avatar Oct 07 '24 09:10 1uc