nmodl icon indicating copy to clipboard operation
nmodl copied to clipboard

Don't include solver headers verbatim.

Open matz-e opened this issue 1 year ago • 11 comments

This first version will create a solver directory to contain the same newton.hpp and crout.hpp as present in the NMODL sources.

By default, NMODL will create the solver headers in the output directory. There are two new arguments to the NMODL invocation:

  • --dump-solvers <solver_names> will dump the corresponding solver/*.hpp files into the specified output directory.
  • --no-dump-solvers will keep a regular NMODL from creating the solver headers.

CI_BRANCHES:NEURON_BRANCH=matz-e/better-solver-dumper

matz-e avatar Jul 15 '24 09:07 matz-e

Logfiles from GitLab pipeline #221815 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Jul 15 '24 09:07 bbpbuildbot

Logfiles from GitLab pipeline #222031 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Jul 16 '24 11:07 bbpbuildbot

Logfiles from GitLab pipeline #222038 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Jul 16 '24 11:07 bbpbuildbot

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (b91c0ea) to head (9d4696a). Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
src/main.cpp 6.25% 15 Missing :warning:
src/codegen/codegen_coreneuron_cpp_visitor.cpp 50.00% 1 Missing :warning:
src/codegen/codegen_neuron_cpp_visitor.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   86.82%   86.72%   -0.10%     
==========================================
  Files         179      179              
  Lines       13684    13700      +16     
==========================================
+ Hits        11881    11882       +1     
- Misses       1803     1818      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 16 '24 15:07 codecov[bot]

This is obsolete.

matz-e avatar Mar 25 '25 08:03 matz-e