nmodl icon indicating copy to clipboard operation
nmodl copied to clipboard

Replace deprecated bison commands

Open JCGoran opened this issue 2 years ago • 6 comments

TODO:

  • [ ] according to the docs, updating name-prefix to api.prefix is a bit non-trivial, and a naive fix results in compilation errors. For reference, here's the relevant section:
    The '%name-prefix "xx"' directive is deprecated in favor of '%define
    api.prefix {xx}' since Bison 3.0, but no warning was issued.  These
    directives are slightly different, you might need to adjust your code.
    %name-prefix renames only symbols with external linkage, while api.prefix
    also renames types and macros, including YYDEBUG, YYTOKENTYPE,
    yytokentype, YYSTYPE, YYLTYPE, etc.
    
    Users of Flex that move from '%name-prefix "xx"' to '%define api.prefix
    {xx}' will typically have to update YY_DECL from
    
    #define YY_DECL int xxlex (YYSTYPE *yylval, YYLTYPE *yylloc)
    
    to
    
    #define YY_DECL int xxlex (XXSTYPE *yylval, XXLTYPE *yylloc)
    

JCGoran avatar Mar 18 '24 09:03 JCGoran

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.30%. Comparing base (7c4a829) to head (2eb369a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         178      178           
  Lines       13263    13263           
=======================================
  Hits        11446    11446           
  Misses       1817     1817           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 18 '24 10:03 codecov-commenter

I never changed this one because Ubuntu still have old bison, IIRC

alkino avatar May 16 '24 06:05 alkino

According to https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md the Ubuntu runner should have Bison 3.5.1, so we should be good as far as versions are concerned.

JCGoran avatar May 16 '24 14:05 JCGoran