nmodl icon indicating copy to clipboard operation
nmodl copied to clipboard

Myers diff algorithm for unit tests

Open ohm314 opened this issue 2 years ago • 5 comments

This is a small new feature for a bit of convenience. This PR adds a proper diff implementation that can be invoked when a unit test fails. Instead of outputting the the raw generated strings and painstakingly comparing them, we can now simply diff them and print formatted output.

For now just one test case was updated as an example for initial feedback.

ohm314 avatar Feb 21 '24 13:02 ohm314

I'd propose thorough (unit-) testing. ~To me it looked like you intentionally broke the tests to show how it would fail. However the tests pass and don't show what this would look like when something fails.~

1uc avatar Feb 21 '24 14:02 1uc

Logfiles from GitLab pipeline #212074 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar May 21 '24 13:05 bbpbuildbot

I'll close this. As discussed, it's not very high priority and unless someone has interest and finds the time this can just stay in a branch.

ohm314 avatar May 27 '24 13:05 ohm314