neurocurator icon indicating copy to clipboard operation
neurocurator copied to clipboard

Focus issue when creating a new annotation

Open christian-oreilly opened this issue 8 years ago • 1 comments

A code regression caused an "Invalid localizer" error showing 3 times when a user want to create a new annotation. This is likely a problem of focus causing and early call to the function used to localize the string of annotated text in the PDF.

christian-oreilly avatar Oct 17 '17 12:10 christian-oreilly

It is not fixable without the architecture redesign... There are too much entry points with different objectives to the same part of code.

For example, it is not possible to not execute, when creating a new annotation, the part of code (see below) responsible for the described behaviour because the 'Save' button is relying on it (verification). Making the saving logic aware of the state ('creating a new annotation') might introduce more problems than fixing this issue this way.

https://github.com/BlueBrain/neurocurator/blob/00e349bb751ceddae6604eb7706bb26e3cb7c26a/neurocurator/annotWidgets.py#L831

pafonta avatar Jul 13 '18 15:07 pafonta