new features: postburst_slow_ahp_values, time_to_postburst_slow_ahp

[AurelienJaquier]

[DrTaDa]

@AurelienJaquier could you remove this print ? https://github.com/BlueBrain/eFEL/blob/master/efel/cppcore/LibV1.cpp#L1964

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.50000% with 142 lines in your changes are missing coverage. Please review.

Project coverage is 91.79%. Comparing base (35730cc) to head (586237f). Report is 95 commits behind head on master.

Files	Patch %	Lines
efel/cppcore/LibV1.cpp	75.00%	18 Missing and 40 partials :warning:
efel/cppcore/LibV2.cpp	81.43%	5 Missing and 26 partials :warning:
efel/api.py	90.00%	12 Missing :warning:
efel/cppcore/Utils.cpp	85.18%	5 Missing and 3 partials :warning:
efel/pyfeatures/isi.py	97.03%	7 Missing :warning:
efel/cppcore/cfeature.cpp	90.16%	5 Missing and 1 partial :warning:
efel/cppcore/cppcore.cpp	82.14%	3 Missing and 2 partials :warning:
efel/pyfeatures/pyfeatures.py	94.50%	5 Missing :warning:
efel/cppcore/DependencyTree.cpp	82.60%	2 Missing and 2 partials :warning:
efel/cppcore/EfelExceptions.h	50.00%	2 Missing :warning:
... and 2 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #289       +/-   ##
===========================================
+ Coverage   57.04%   91.79%   +34.75%     
===========================================
  Files          30       36        +6     
  Lines        7847     6888      -959     
  Branches     3274     2241     -1033     
===========================================
+ Hits         4476     6323     +1847     
+ Misses        851      293      -558     
+ Partials     2520      272     -2248     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[AurelienJaquier]

@DrTaDa done :)

[DrTaDa]

@DrTaDa done :)

Thanks ! You'r the best

[AurelienJaquier]

This should solve Issue #282

[anilbey]

Thanks looks good to me. There is also the https://github.com/BlueBrain/eFEL/pull/334 PR which reduces the repetitiveness in the C++ code base.

For example, instead of having different functions for inv_first_ISI, inv_second_ISI ... inv_fifth_ISI, it just uses the following to have a single implementation.

  FptrTableV5["inv_first_ISI"] = [](mapStr2intVec& intData,
                                    mapStr2doubleVec& doubleData,
                                    mapStr2Str& strData) {
    return LibV5::inv_ISI_generic(intData, doubleData, strData, 0);
  };
  FptrTableV5["inv_second_ISI"] = [](mapStr2intVec& intData,
                                     mapStr2doubleVec& doubleData,
                                     mapStr2Str& strData) {
    return LibV5::inv_ISI_generic(intData, doubleData, strData, 1);
  };
  FptrTableV5["inv_third_ISI"] = [](mapStr2intVec& intData,
                                    mapStr2doubleVec& doubleData,
                                    mapStr2Str& strData) {
    return LibV5::inv_ISI_generic(intData, doubleData, strData, 2);
  };

After #334 is merged, this PR can be written much shorter (perhaps even reduced by half). Would it be possible to hold off on merging this PR until after #334 is completed?

[AurelienJaquier]

@anilbey sure we can wait, no problem. This is waiting from April anyway

[AurelienJaquier]

After #334 is merged, this PR can be written much shorter (perhaps even reduced by half).

Alright, done in latest commits.

This PR is ready to be merged on my side.