eFEL icon indicating copy to clipboard operation
eFEL copied to clipboard

postburst_min_values (and interburst_min_values) - don't work as expected - fast AHP after last spike in burst reported instead of slow AHP.

Open PolinaL opened this issue 2 years ago • 6 comments

Both postburst_min_values and _interburst_min_values seem to measure the fast AHP right after last spike, and not the slow AHP between bursts, as expected. Please see attached trace (model in purple, experimental data in color) - postburst_min_values exp. data extracted value is "mean": -78.15430187470984, "original_std": 2.88731485936629, model value is -78.60786914391257. RTN_EI_params_64339_ZOOMEDCell#2_Jul_9_Step_ReboundBurstProtocol_burst_-300 Thanks.

PolinaL avatar Mar 28 '23 13:03 PolinaL

time and voltage data for both model and experimental traces time_and_voltage.zip

PolinaL avatar Mar 28 '23 14:03 PolinaL

Here is a zoom, they appear on top of each other, but the red one should be at around -60 instead of at the fast AHP. I think it's because the fast AHP is lower than the slow one, but @PolinaL would like to eventually capture both, so she could control which one is lower zoom

arnaudon avatar Mar 28 '23 14:03 arnaudon

I suppose it should be a shift around here: https://github.com/BlueBrain/eFEL/blob/master/efel/cppcore/LibV5.cpp#L3881 but I don't understand cpp and this code enough to try to do it unfortunately...

arnaudon avatar Mar 28 '23 15:03 arnaudon

@PolinaL , try this: https://github.com/BlueBrain/eFEL/pull/283 , it solves it for the trace you shared: zoom

arnaudon avatar Mar 31 '23 07:03 arnaudon

Hi! I did a c++ implementation that solves your problem in PR #289

With it, we have two new features: postburst_slow_ahp_values and time_to_postburst_slow_ahp

The features start searching for the minimum at a given number of ms after the spike, in order to skip the fast ahp. The number of ms to skip is given by the setting sahp_start and is 5 ms by default.

For your trace @PolinaL 5 ms is not enough, but it works if we increase it to 10 ms with the following command before calling efel:

efel.setDoubleSetting('sahp_start', 10.)

AurelienJaquier avatar Apr 17 '23 09:04 AurelienJaquier

Hi @PolinaL ! Did the new features in PR #289 solve your problem? If so, I will merge the PR and close this issue

AurelienJaquier avatar Oct 12 '23 08:10 AurelienJaquier

I'll close this issue since the related PR has been merged

AurelienJaquier avatar Apr 29 '24 14:04 AurelienJaquier

I'll also close the postburst-slow-ahp branch. You can use the master branch now, it contains all the post-burst features

AurelienJaquier avatar Apr 29 '24 15:04 AurelienJaquier