eFEL icon indicating copy to clipboard operation
eFEL copied to clipboard

Support eFeatures written in Python

Open wvangeit opened this issue 10 years ago • 3 comments

It would be handy if the eFEL would support eFeatures written by users in pure python, without requiring a C++ implementation

wvangeit avatar Sep 29 '15 12:09 wvangeit

Hi, Does it work? Can I use my own python written functions? Thanks.

orena1 avatar Jun 29 '18 10:06 orena1

Yes, more or less. I still need to write some documentation on how to exactly add your own features. But I think it's fairly easy to figure it out based on how this feature was implemented: https://github.com/BlueBrain/eFEL/blob/master/efel/pyfeatures/pyfeatures.py#L91 As a general rules, when implementing a new feature try to reuse as much as possible the existing cpp features (to detect spikes etc). At some point these will be rewritten in python, but if people now start using their own implementation things might get very messy. One caveat mentioned here: https://github.com/BlueBrain/eFEL/issues/131 The getDistance function doesnt accept python features yet. So it wouldnt work with bluepyopt yet. Let me know if you need that urgently and I will bump it up on my priority list.

wvangeit avatar Jun 29 '18 10:06 wvangeit

@orena1 This PR adds the python features to getDistance(): #135

This pypi version includes that code: https://pypi.org/project/efel/3.0.12/

wvangeit avatar Jul 05 '18 12:07 wvangeit