Search icon indicating copy to clipboard operation
Search copied to clipboard

Type annotate existing code

Open jankrepl opened this issue 4 years ago • 2 comments

🚀 Feature

I think we can incrementally start annotating existing code. It shouldn't really take that long and it could be a really nice way to practice and learn about typing.

Pitch

The more code we annotate the more powerful the typechecking will become.

Alternatives

The alternative is to do nothing and just add types to new code as agreed.

jankrepl avatar Mar 17 '21 10:03 jankrepl

Hi @jankrepl , is this Issue something that you would like to be "Done" in a PR?

Concerning the incremental type annotation of code, do you suggest to do something different from what we already have in our PR Checklist (see here)?

  • [ ] Type annotations added. (if a function is added or modified)

FrancescoCasalegno avatar May 04 '21 13:05 FrancescoCasalegno

@FrancescoCasalegno The wording of this issue is actually really confusing. What I meant is type annotating our entire existing codebase. By incrementally I meant that this can be split up into multiple smaller PRs (annotate module_1.py, annotate module_2.py, etc..)

jankrepl avatar May 04 '21 13:05 jankrepl