NeuroM icon indicating copy to clipboard operation
NeuroM copied to clipboard

Make fork iterators homogeneous

Open eleftherioszisis opened this issue 2 years ago • 2 comments

eleftherioszisis avatar Apr 25 '22 13:04 eleftherioszisis

only the tests/test_mixed.py tests fail, does that mean this is backwards compat?

mgeplf avatar Apr 27 '22 06:04 mgeplf

only the tests/test_mixed.py tests fail, does that mean this is backwards compat?

Nope. The test_mixed.py tests both subtree enabled and disabled feature calculation.

However, it is true that for a morphology with homogeneous neurites, there would be no backward break because of these iterators. Only in the case of artifacts, e.g. a mistyped section, the homogeneous fork iterator would skip the forking point.

eleftherioszisis avatar Apr 27 '22 07:04 eleftherioszisis

Closing for now. We may revisit it in the future.

eleftherioszisis avatar Apr 16 '24 10:04 eleftherioszisis