CoreNeuron icon indicating copy to clipboard operation
CoreNeuron copied to clipboard

Allow for explicit non-aligned allocation

Open ohm314 opened this issue 1 year ago • 2 comments

  • Protect aligned_alloc from potentially invalid 0 alignment argument
  • Handle alignment = 0 as normal malloc
  • Allocate MembList and ThreadMembList objects without alignment. They are small objects and cannot be allocated with alignment when using the std::aligned_alloc function (without extra fill).

CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop

ohm314 avatar Sep 22 '22 13:09 ohm314

Getting some benchmarks here: https://bbpgitlab.epfl.ch/hpc/cellular/coreneuron-perf-tests/-/pipelines/75464

ohm314 avatar Sep 22 '22 14:09 ohm314

Logfiles from GitLab pipeline #75461 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Sep 22 '22 15:09 bbpbuildbot

@olupton : I forgot to merge this one, could you take a look please?

ohm314 avatar Oct 12 '22 10:10 ohm314

Logfiles from GitLab pipeline #78380 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Oct 12 '22 11:10 bbpbuildbot

Logfiles from GitLab pipeline #78454 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Oct 12 '22 14:10 bbpbuildbot

Logfiles from GitLab pipeline #78614 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Oct 13 '22 10:10 bbpbuildbot

Logfiles from GitLab pipeline #79221 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot avatar Oct 17 '22 10:10 bbpbuildbot