CoreNeuron icon indicating copy to clipboard operation
CoreNeuron copied to clipboard

Published 20 hours ago • verified publisher icon BlueBrain

GitLab CI does not test NMODL's analytic sympy solver

Open olupton opened this issue 3 years ago • 1 comments

The CPU https://github.com/BlueBrain/CoreNeuron/blob/9c821d51e90237827e5e70fe76748bc54612913a/.gitlab-ci.yml#L74 and GPU https://github.com/BlueBrain/CoreNeuron/blob/9c821d51e90237827e5e70fe76748bc54612913a/.gitlab-ci.yml#L93 builds of CoreNEURON against NMODL do not set the sympy variant, so the sympy analytic solver is not tested in the CI.

It would be good to also test this code path. Ideally we would not add more builds to the CI, so it might be better to extend some relevant tests (configured in NEURON) to duplicate themselves with sympy --analytic where CoreNEURON and NMODL are enabled.

olupton avatar Sep 02 '21 09:09 olupton

Note that we do now set +sympy in one of the three CoreNEURON + NMODL builds: https://github.com/BlueBrain/CoreNeuron/blob/fa24f3eab580160f0ec790ef9e99af12adf78475/.gitlab-ci.yml#L128 but I still like the idea of extending the test suite in NEURON to cover more of these cases inside a single build.

olupton avatar Feb 03 '22 16:02 olupton

I think the residual part of this issue is covered by https://github.com/BlueBrain/CoreNeuron/issues/344

olupton avatar Aug 25 '22 07:08 olupton