BluePyOpt icon indicating copy to clipboard operation
BluePyOpt copied to clipboard

fix python crash with NEURON8.1.0

Open arnaudon opened this issue 2 years ago • 7 comments

this is fix related to CELLS-42

arnaudon avatar Jun 15 '22 13:06 arnaudon

Did you test this with older versions of Neuron?

wvangeit avatar Jun 15 '22 13:06 wvangeit

Codecov Report

Merging #405 (a04df7a) into master (8a25348) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   90.49%   90.50%   +0.01%     
==========================================
  Files          41       41              
  Lines        2473     2476       +3     
==========================================
+ Hits         2238     2241       +3     
  Misses        235      235              
Impacted Files Coverage Δ
bluepyopt/ephys/simulators.py 96.59% <100.00%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a25348...a04df7a. Read the comment docs.

codecov-commenter avatar Jun 15 '22 13:06 codecov-commenter

I close this, this is not solving it, it's an issue with ipyparallel, with dask it works without this. Sorry for the noise here.

arnaudon avatar Jun 16 '22 21:06 arnaudon

it's an issue with ipyparallel

What's the issue w/ ipyparallel?

mgeplf avatar Jun 17 '22 07:06 mgeplf

@mgeplf when using ipyparallel, when NEURON crashes, it also crashed the whole python script (core dump). The issue is being investigated in the ticket CELLS-42

DrTaDa avatar Jun 17 '22 07:06 DrTaDa

Thanks; I'll follow along there.

mgeplf avatar Jun 17 '22 08:06 mgeplf

In fact, this is needed with for example dask-mpi parallelization to prevent neuron to send kill signal and crash everything.

arnaudon avatar Jul 15 '22 07:07 arnaudon