python-blosc2 icon indicating copy to clipboard operation
python-blosc2 copied to clipboard

Run `mypy` in CI?

Open DimitriPapadopoulos opened this issue 1 year ago • 3 comments

Add to .pre-commit-config.yaml to enforce that:

-   repo: https://github.com/pre-commit/mirrors-mypy
    rev: v1.13.0
    hooks:
     -  id: mypy
        files: "src"

DimitriPapadopoulos avatar Nov 02 '24 10:11 DimitriPapadopoulos

That would be worth a try.

FrancescAlted avatar Nov 02 '24 16:11 FrancescAlted

I would need help to fix all issues:

$ mypy src/blosc2
[...]
Found 170 errors in 8 files (checked 10 source files)
$ 

Static typing annotations are not useful without running a static type checker.

DimitriPapadopoulos avatar Nov 02 '24 17:11 DimitriPapadopoulos

Ok, this is a major task. Will have to be deferred probably after 3.0.0-rc1 which is coming soon.

FrancescAlted avatar Nov 03 '24 09:11 FrancescAlted