bcolz icon indicating copy to clipboard operation
bcolz copied to clipboard

Published 20 hours ago • verified publisher icon Blosc

EAFP when reading schunk and use ujson if available

Open bordingj opened this issue 7 years ago • 4 comments

#318 #319

bordingj avatar May 07 '17 15:05 bordingj

Coverage Status

Coverage decreased (-0.3%) to 65.114% when pulling ba25bb3e97f392c85a10cb5ae6f3912ebfd775d7 on bordingj:EAFP into 8df64b4c228ffd2ffcbdea94b393e26578f4c8f9 on Blosc:master.

coveralls avatar May 07 '17 15:05 coveralls

Looks good to me. Any performance hints on how much this PR can accelerate things? Could you add some estimates to the RELEASE_NOTES files?

FrancescAlted avatar May 08 '17 08:05 FrancescAlted

In my benchmarks read-speed is ~2% faster

bordingj avatar May 10 '17 17:05 bordingj

Ok, so 2% is not really significant, although your modifications are not too intrusive, so I am still open to accept this PR. Thanks!

FrancescAlted avatar May 10 '17 17:05 FrancescAlted