Add RPC encryption CA reg key
Description
Collection of additional CA reg key value (RPC encryption enforcement)
Motivation and Context
This change is required for ADCS ESC11 coverage.
Corresponding BHCE PR: https://github.com/SpecterOps/BloodHound/pull/1679
Resolves BED-6182
How Has This Been Tested?
Locally in lab.
Types of changes
- [ ] Chore (a change that does not modify the application functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] Documentation updates are needed, and have been made accordingly.
- [ ] I have added and/or updated tests to cover my changes.
- [x] All new and existing tests passed.
- [ ] My changes include a database migration.
Summary by CodeRabbit
- New Features
- Added the ability to check and display whether RPC encryption enforcement is enabled for a Certification Authority on a target host.
Walkthrough
A new property, RPCEncryptionEnforced, was added to the CARegistryData class to store the result of an RPC encryption enforcement check. Additionally, a new method, RPCEncryptionEnforced, was introduced in the CertAbuseProcessor class to determine if RPC encryption is enforced for a specific Certification Authority by inspecting a registry flag.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
CARegistryData Property Additionsrc/CommonLib/OutputTypes/CARegistryData.cs |
Added public property RPCEncryptionEnforced of type BoolRegistryAPIResult to the CARegistryData class. |
CertAbuseProcessor Method Additionsrc/CommonLib/Processors/CertAbuseProcessor.cs |
Added public method RPCEncryptionEnforced to check registry for RPC encryption enforcement for a given CA. |
Sequence Diagram(s)
sequenceDiagram
participant Caller
participant CertAbuseProcessor
participant Registry
Caller->>CertAbuseProcessor: RPCEncryptionEnforced(target, caName)
CertAbuseProcessor->>Registry: Read InterfaceFlags from SYSTEM\...\<caName>
Registry-->>CertAbuseProcessor: Return InterfaceFlags value
CertAbuseProcessor-->>Caller: Return BoolRegistryAPIResult (enforced or not)
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~7 minutes
Poem
A bunny hopped through code today,
To check if RPC is locked away.
With a flag in the registry,
Encryption enforced—now plain to see!
New methods bloom, new data grows,
In the warren where the logic flows.
🐇✨
[!NOTE]
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ac60f8f22b2432c89b51ed6795341bd3bb195607 and c2305953398d9e54ed381d2c5fb131c9907c2e67.
📒 Files selected for processing (2)
src/CommonLib/OutputTypes/CARegistryData.cs(1 hunks)src/CommonLib/Processors/CertAbuseProcessor.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
src/CommonLib/OutputTypes/CARegistryData.cs (1)
11-11: LGTM! Property follows established patterns.The new
RPCEncryptionEnforcedproperty follows the same pattern as other registry result properties in the class and has a clear, descriptive name indicating its purpose.src/CommonLib/Processors/CertAbuseProcessor.cs (1)
280-305: LGTM! Method implementation follows established patterns.The new
RPCEncryptionEnforcedmethod follows the same implementation pattern as other similar registry checking methods in the class (IsUserSpecifiesSanEnabled,RoleSeparationEnabled). It properly handles error cases, null values, and uses appropriate bitwise operations to check the RPC encryption enforcement flag (0x00000200).
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
- [ ] Commit unit tests in branch
esc11
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai generate unit teststo generate unit tests for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.