SharpHoundCommon Add DisabledExtensions CA reg key

Description

Collection of CA registry key DisabledExtensions for ADCS ESC16 edge

Also updates the collection of CA reg key setting IsUserSpecifiesSanEnabled to support custom reg key paths.

Motivation and Context

Tickets: BED-6176

How Has This Been Tested?

Locally in lab environment.

Types of changes

[ ] Chore (a change that does not modify the application functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] Documentation updates are needed, and have been made accordingly.
[ ] I have added and/or updated tests to cover my changes.
[x] All new and existing tests passed.
[ ] My changes include a database migration.

Summary by CodeRabbit

New Features
- Added the ability to retrieve a list of disabled certificate authority extensions.
Improvements
- Enhanced logic for detecting user-specified Subject Alternative Name (SAN) settings by dynamically identifying the active policy.
Bug Fixes
- Improved error handling for missing or inaccessible registry values when retrieving certificate authority policy settings.

Aug 04 '25 12:08 JonasBK

Walkthrough

A new API result class for returning string arrays was introduced. The CARegistryData class now includes a property for disabled extensions using this new result type. The CertAbuseProcessor class was updated to dynamically determine the active policy when querying registry values and now includes a method to retrieve disabled extensions.

Changes

Cohort / File(s)	Change Summary
New API Result Class `src/CommonLib/OutputTypes/StringArrayRegistryAPIResult.cs`	Added `StringArrayRegistryAPIResult`, a public class inheriting from `APIResult` with a `string[] Data` property.
CARegistryData Property Addition `src/CommonLib/OutputTypes/CARegistryData.cs`	Added `DisabledExtensions` property of type `StringArrayRegistryAPIResult` to `CARegistryData`.
CertAbuseProcessor Enhancements `src/CommonLib/Processors/CertAbuseProcessor.cs`	Updated `IsUserSpecifiesSanEnabled` to use the active policy subkey; added `DisabledExtensions` method to read disabled extension list.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant CertAbuseProcessor
    participant Registry

    Caller->>CertAbuseProcessor: IsUserSpecifiesSanEnabled(target, caName)
    CertAbuseProcessor->>Registry: Read "Active" from PolicyModules
    Registry-->>CertAbuseProcessor: Return activePolicyName
    CertAbuseProcessor->>Registry: Read "EditFlags" from activePolicyName subkey
    Registry-->>CertAbuseProcessor: Return EditFlags value
    CertAbuseProcessor-->>Caller: Return BoolRegistryAPIResult

    Caller->>CertAbuseProcessor: DisabledExtensions(target, caName)
    CertAbuseProcessor->>Registry: Read "Active" from PolicyModules
    Registry-->>CertAbuseProcessor: Return activePolicyName
    CertAbuseProcessor->>Registry: Read "DisableExtensionList" from activePolicyName subkey
    Registry-->>CertAbuseProcessor: Return string[] of disabled extensions
    CertAbuseProcessor-->>Caller: Return StringArrayRegistryAPIResult

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

In the registry fields where the data arrays grow,
New classes and properties now gently bestow.
Policies shift, their actives revealed,
Extensions disabled, their fates now unsealed.
With every key queried, the code hops anew—
A rabbit’s delight in the work that you do! 🐇✨

[!NOTE]

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

[ ] 📝 Generate Docstrings

🧪 Generate unit tests

[ ] Create PR with unit tests
[ ] Post copyable unit tests in a comment
[ ] Commit unit tests in branch esc16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Aug 04 '25 13:08 coderabbitai[bot]

Walkthrough

A new API result class for string arrays was introduced. The CARegistryData class now includes a property for disabled extensions using this new result type. The CertAbuseProcessor class was refactored to dynamically determine the active policy subkey from the registry and includes a new method to retrieve disabled extensions. Error handling and control flow were improved.

Changes

Cohort / File(s)	Change Summary
API Result Type for String Arrays `src/CommonLib/OutputTypes/APIResults/StringArrayRegistryAPIResult.cs`	Added `StringArrayRegistryAPIResult` class inheriting from `APIResult`, with a `Data` property of type `string[]` initialized to an empty array.
CA Registry Data Extension `src/CommonLib/OutputTypes/CARegistryData.cs`	Added a new public property `DisabledExtensions` of type `StringArrayRegistryAPIResult` to the `CARegistryData` class.
CertAbuseProcessor Refactor & Extension `src/CommonLib/Processors/CertAbuseProcessor.cs`	Refactored `IsUserSpecifiesSanEnabled` to dynamically resolve the policy subkey; added `DisabledExtensions` method to retrieve disabled extensions from the registry; improved error handling.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant CertAbuseProcessor
    participant Registry

    Caller->>CertAbuseProcessor: DisabledExtensions(target, caName)
    CertAbuseProcessor->>Registry: Read "Active" value from PolicyModules
    alt "Active" value exists
        CertAbuseProcessor->>Registry: Read "DisableExtensionList" from active policy subkey
        Registry-->>CertAbuseProcessor: Return string array or error
    else No "Active" value
        CertAbuseProcessor->>Registry: Use default policy subkey, read "DisableExtensionList"
        Registry-->>CertAbuseProcessor: Return string array or error
    end
    CertAbuseProcessor-->>Caller: Return StringArrayRegistryAPIResult

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny hopped through code so neat,
New string arrays, a tidy feat!
Extensions disabled, now easy to find,
With registry reads smartly aligned.
Refactors done, errors in check—
This rabbit’s work is quite the tech! 🐇✨

[!NOTE]

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

[ ] 📝 Generate Docstrings

🧪 Generate unit tests

[ ] Create PR with unit tests
[ ] Post copyable unit tests in a comment
[ ] Commit unit tests in branch esc16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Aug 04 '25 13:08 coderabbitai[bot]

Add DisabledExtensions CA reg key

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

CodeRabbit Configuration File (`.coderabbit.yaml`)

CodeRabbit Configuration File (`.coderabbit.yaml`)